Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling special handling of "Creator properties" wrt alphabetic property ordering #2879

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Add support for disabling special handling of "Creator properties" wrt alphabetic property ordering #2879

merged 2 commits into from
Oct 24, 2020

Conversation

siy
Copy link
Contributor

@siy siy commented Oct 12, 2020

Support for strict property ordering re-applied to 2.12

@cowtowncoder
Copy link
Member

cowtowncoder commented Oct 15, 2020

Thank you! Apologies for the slow follow up; I just wanted to add a note that I am still following up on this and plan on getting it included in 2.12 (possibly in 2.12.0-rc2). There is bit of a backlog but I have not forgotten. :-)

One thing I'd need to merge this (unless I have asked for it already) is CLA from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

which is usually easiest to do by printing, filling & signing, scan/photo, email to info at fasterxml dot com. Only needs to be done once, before the first contribution.

@cowtowncoder
Copy link
Member

Ok: the change looks good, and once I get CLA I can merge it. I will probably change the name of feature to indicate that it specifically determines whether "Creator properties" get sorted preferentially, but would not override explicit ordering (with @JsonPropertyOrder), but other than that it's fine.
I'll actually go ahead and add one explicit test to verify my understanding here is correct.

cowtowncoder added a commit that referenced this pull request Oct 18, 2020
@siy
Copy link
Contributor Author

siy commented Oct 19, 2020

Sorry for delays. I'll send signed CLA as soon as I'll be able to reach my printer. Unfortunately I'm in the middle of relocation to another town, so it will take a couple days.

@cowtowncoder
Copy link
Member

@siy No problem, there is time, thank you for adding an update so I know the state of things.

One thing I have noticed is that some contributors have managed to add signature digitally (getting an image of signature, scanning or probably there's an app for that), paste on pdf document; that's fine for us as well.
So printing part is not absolutely required. I wish we had a better way to handle this in general.

Anyway: thank you for this contribution & we get it merged when we can!

@siy
Copy link
Contributor Author

siy commented Oct 20, 2020

I did send signed CLA to mentioned above e-mail address.

@cowtowncoder cowtowncoder added this to the 2.12.0-rc2 milestone Oct 24, 2020
@cowtowncoder cowtowncoder merged commit 75bd749 into FasterXML:2.12 Oct 24, 2020
@cowtowncoder cowtowncoder changed the title Add support for strict property ordering Add support for disabling special handling of "Creator properties" wrt alphabetic property ordering Oct 24, 2020
cowtowncoder added a commit that referenced this pull request Oct 24, 2020
@cowtowncoder
Copy link
Member

Thank you -- I finally got to merging this, will go in 2.12.0-rc2.

I renamed property to MapperFeature.SORT_CREATOR_PROPERTIES_FIRST (default state true), but logic otherwise should be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants