-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module-info.java
is in META-INF/versions/11
instead of META-INF/versions/9
#3380
Comments
Hard no for Automatic-Module-Name: that should not be reintroduced (and doing so would likely cause issues with module awareness); there is no real upside here. But I think this issue was earlier filed as: https://github.com/FasterXML/jackson/issues/96 (which is not necessarily optimal place but it is what it is) so follow-up discussion should go there. I am not against change to version baseline since it sounds like some tooling might suffer from use of JVM 11 over JVM 9. Note, too, that I think Jackson 2.10 - 2.12 have module-info.class in different location (with different trade-offs): Automatic name was replaced with proper name in 2.10.0 as per #2273. |
More info from FasterXML/jackson-modules-base#126 : I think change needed in |
Fix at: /cc @GedMarc |
Fixed via: but will add separate release note entry for convenience. |
module-info.java
is in META-INF/versions/11
instead of META-INF/versions/9
Should this be closed since the fix was released? |
Thank you @pjfanning , yes. |
We build a lib using Jackson databind.
In 2.9.3 you had no
module-info.java
, but anAutomatic-Module-Name
in the manifest.We wanted to update the used verison, but now you have a
module-info.java
file inMETA-INF/versions/11
and noAutomatic-Module-Name
anymore.This effectively changes your module name for builds for Java 9 and 10 to being deduced from the JAR file name which is pretty bad.
We still are Java 8 compatible, so building our
module-info.java
to be compatible with Java 9 which now does not work properly anymore as the compiler complains that the module is not present.Please put the
module-info.java
to the proper placeMETA-INF/versions/9
or at least reintroduce theAutomatic-Module-Name
manifest attribute.The text was updated successfully, but these errors were encountered: