Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlReadContext does not keep track of array index #397

Closed
cowtowncoder opened this issue May 13, 2020 · 1 comment
Closed

XmlReadContext does not keep track of array index #397

cowtowncoder opened this issue May 13, 2020 · 1 comment
Milestone
2.12.0

Comments

@cowtowncoder
Copy link
Member

Looks like location tracking for XmlReadContext does not update array index unlike other parsers. This makes path JsonReadContext.pathAsPointer() less useful than it could be.
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone May 13, 2020
@cowtowncoder
Copy link
Member Author

Verifying the fix is actually trickier than initial fix since low-level FromXmlParser usage difficult.
So for now will just do manual verification via getParsingContext().pathAsPoint(), printing that out from tests.

alex-bel-apica pushed a commit to ApicaSystem/jackson-dataformat-xml that referenced this issue Sep 4, 2020
@cowtowncoder @alex-bel-apica
Fix FasterXML#397 (alas, no unit tests)
98e0dfe 
# Conflicts:
#	release-notes/VERSION-2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
1 participant
@cowtowncoder