Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAMLGenerator serializes string with special chars unquoted when using MINIMIZE_QUOTES mode #180

Closed
trohrberg opened this issue Mar 12, 2020 · 0 comments
Closed

YAMLGenerator serializes string with special chars unquoted when using MINIMIZE_QUOTES mode #180

trohrberg opened this issue Mar 12, 2020 · 0 comments
Labels
yaml Issue related to YAML format backend
Milestone
2.11.0

Comments

@trohrberg
Copy link
Contributor

When using the YAMLGenerator in the MINIMIZE_QUOTES mode, the generator serializes strings in plain style, i.e. without quoting them. However, as stated in the YAML Spec such plain style strings cannot contain some special characters such as ':', ',', and others.

As with the serialization of boolean-like strings, the YAMLGenerator should be adjusted to always quote strings containing those special characters.

I will shortly try to provide a pull request to fix this issue.
trohrberg added a commit to trohrberg/jackson-dataformats-text that referenced this issue Mar 12, 2020
@trohrberg
FIX FasterXML#180: YAML Generator now quotes strings containing speci…
2abe0fa 
…al chars

When using the YAMLGenerator in the MINIMIZE_QUOTES mode, the generator serializes strings in plain style, i.e. without quoting them. However, as stated in the YAML Spec [1] such plain style strings cannot contain some special characters such as ':', ',', and others.

[1] https://yaml.org/spec/1.2/spec.html#id2788859

As with the serialization of boolean-like strings, the YAMLGenerator should be adjusted to always quote strings containing those special characters.

I will shortly try to provide a pull request to fix this issue.
trohrberg added a commit to trohrberg/jackson-dataformats-text that referenced this issue Mar 13, 2020
@trohrberg
FIX FasterXML#180: YAML Generator now quotes strings containing speci…
0d3eeec 
…al chars

When using the YAMLGenerator in the MINIMIZE_QUOTES mode, the generator serializes strings in plain style, i.e. without quoting them. However, as stated in the YAML Spec [1] such plain style strings cannot contain some special characters such as ':', ',', and others.

[1] https://yaml.org/spec/1.2/spec.html#id2788859

As with the serialization of boolean-like strings, the YAMLGenerator should be adjusted to always quote strings containing those special characters.

I will shortly try to provide a pull request to fix this issue.
@cowtowncoder cowtowncoder added 2.11 yaml Issue related to YAML format backend labels Mar 13, 2020
@trohrberg trohrberg mentioned this issue Mar 16, 2020
Merged
@cowtowncoder cowtowncoder changed the title [YAML] Generator serializes string with special chars unquoted when using MINIMIZE_QUOTES mode YAMLGenerator serializes string with special chars unquoted when using MINIMIZE_QUOTES mode Mar 16, 2020
@cowtowncoder cowtowncoder added this to the 2.11.0 milestone Mar 16, 2020
cowtowncoder added a commit that referenced this issue Mar 16, 2020
@cowtowncoder
Add release notes, minor changes to #180
ee1a1d0
cowtowncoder added a commit that referenced this issue Mar 16, 2020
@cowtowncoder
one minor tweak wrt #180
a4501bc
trohrberg added a commit to trohrberg/jackson-dataformats-text that referenced this issue Apr 7, 2020
@trohrberg
FIX FasterXML#180: YAML Generator now quotes strings containing speci…
3abaab2 
…al chars

When using the YAMLGenerator in the MINIMIZE_QUOTES mode, the generator serializes strings in plain style, i.e. without quoting them. However, as stated in the YAML Spec [1] such plain style strings cannot contain some special characters such as ':', ',', and others.

[1] https://yaml.org/spec/1.2/spec.html#id2788859

As with the serialization of boolean-like strings, the YAMLGenerator should be adjusted to always quote strings containing those special characters.

I will shortly try to provide a pull request to fix this issue.
frantuma added a commit to frantuma/jackson-dataformats-text that referenced this issue Jun 3, 2020
@frantuma
REF FasterXML#180 - updates scalars with indicators quoting style
3f19afe
frantuma added a commit to frantuma/jackson-dataformats-text that referenced this issue Jun 3, 2020
@frantuma
REF FasterXML#180 - updates scalars with indicators quoting style
d04202d
@frantuma frantuma mentioned this issue Jun 3, 2020
Merged
cowtowncoder pushed a commit that referenced this issue Jun 4, 2020
@frantuma @cowtowncoder
REF #180 - updates scalars with indicators quoting style
21d1f67
@bjpe bjpe mentioned this issue Nov 5, 2020
Open
@jameswynn jameswynn mentioned this issue Jun 4, 2021
Closed
Undin added a commit to JetBrains/educational-plugin that referenced this issue Sep 14, 2022
@Undin
Update version of jackson dependencies
3e2d0ba 
Also, drop redundant explicit transitive dependencies because we don't need them anymore

Note, new version of `jackson-dataformat-yaml` library serialize `Date` objects using quotes (see FasterXML/jackson-dataformats-text#180)
Undin added a commit to JetBrains/educational-plugin that referenced this issue Sep 14, 2022
@Undin
Update version of jackson dependencies
5977295 
Also, drop redundant explicit transitive dependencies because we don't need them anymore

Note, new version of `jackson-dataformat-yaml` library serialize `Date` objects using quotes (see FasterXML/jackson-dataformats-text#180)
Undin added a commit to JetBrains/educational-plugin that referenced this issue Sep 27, 2022
@Undin
Update version of jackson dependencies
2ca7685 
Also, drop redundant explicit transitive dependencies because we don't need them anymore

Note, new version of `jackson-dataformat-yaml` library serialize `Date` objects using quotes (see FasterXML/jackson-dataformats-text#180)
Undin added a commit to JetBrains/educational-plugin that referenced this issue Sep 28, 2022
@Undin
Update version of jackson dependencies
27f8a27 
Also, drop redundant explicit transitive dependencies because we don't need them anymore

Note, new version of `jackson-dataformat-yaml` library serialize `Date` objects using quotes (see FasterXML/jackson-dataformats-text#180)
Undin added a commit to JetBrains/educational-plugin that referenced this issue Sep 28, 2022
@Undin
Update version of jackson dependencies
8e35f40 
Also, drop redundant explicit transitive dependencies because we don't need them anymore

Note, new version of `jackson-dataformat-yaml` library serialize `Date` objects using quotes (see FasterXML/jackson-dataformats-text#180)
@cowtowncoder cowtowncoder mentioned this issue Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
yaml Issue related to YAML format backend
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@cowtowncoder @trohrberg