Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shading behavior of jackson-jr-all is surprising. #42

Closed
adamv opened this issue May 5, 2016 · 4 comments
Closed

Shading behavior of jackson-jr-all is surprising. #42

adamv opened this issue May 5, 2016 · 4 comments

Comments

@adamv
Copy link

adamv commented May 5, 2016

In this repo: https://github.com/adamv/jr-shade

I'm including jackson-jr-all as a dependency, and shading it so that neither it nor jackson-core leak downstream. When do mvn package, then unzip the resulting fat jar I see two copies of jackson-core, one shaded one unshaded (which I think it is picking up through the parent pom?)

To get a properly shaded library I need to exclude the jackson-core dependency:
https://github.com/adamv/jr-shade/blob/master/pom.xml#L51

I'm not sure if this is expected behavior or not. If so, it would be helpful for this project to document the maven dependency w/ the exclusion included.

@cowtowncoder
Copy link
Member

Obviously the goal is for there to only be shaded copy, and that no dependency would be leaked.

You may be right about parent pom -- dependency does not really belong there, just dependencyManagement section. I'll change that. Would be it easy for you to see that 2.7.5-SNAPSHOT behaves better?

@adamv
Copy link
Author

adamv commented May 5, 2016

Is there a maven repo I can use to pull down the SNAPSHOT, or is the best course of action to compile & install locally?

@adamv
Copy link
Author

adamv commented May 5, 2016

Checked out sources locally, 2.7.5-SNAPSHOT appears to have corrected this. Thanks!

@cowtowncoder
Copy link
Member

I did mvn deploy so hopefully it goes to Sonatype Maven also. Thank you for reporting this & verifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants