You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had to remove an unnecessary 'static lifetime bound in hyper, so that we can mut-borrow connections to it. Currently the socks server needs this, because it wants to shut down the connections once the layer stack is done. But it is generally better not to require the connection to be static.
The workspace Cargo.toml contains a patch section to use my fix:
non-static IO might actually interfere with protocol upgrades. hyper can only create Upgraded for static IO, because the IO object is sent through an oneshot channel. I'm not sure how it compiles with non-static IO - and servers didn't require a static lifetime even before my patch.
I found more unnecessary and annoying trait/lifetime bounds and removed them. I didn't open a PR, but might later. For now we can just use the patch with my forked repo.
I had to remove an unnecessary
'static
lifetime bound in hyper, so that we can mut-borrow connections to it. Currently the socks server needs this, because it wants to shut down the connections once the layer stack is done. But it is generally better not to require the connection to be static.The workspace
Cargo.toml
contains apatch
section to use my fix:Once the PR is merged upstream (and released), we can remove that
patch
.The text was updated successfully, but these errors were encountered: