Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable tests/007.phpt #42

Open
Jon4t4n opened this issue Dec 28, 2022 · 2 comments
Open

Fix and re-enable tests/007.phpt #42

Jon4t4n opened this issue Dec 28, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Jon4t4n
Copy link
Contributor

Jon4t4n commented Dec 28, 2022

tests/007phpt was disabled in PR #39. We want to fix this and re-enable the test.

@MartinKoeditz
Copy link
Collaborator

Two issues fixed.

  1. Precision of PHP has to be set to correct value. Set it to 18 via ini_set().
  2. Since PHP 8.1: Deprecated: Implicit conversion from float-string to int loses precision. Corrected to explicit conversion.

See https://github.com/FirebirdSQL/php-firebird/commit/2a6bf543c96079312245994ef25336bd09c662ec

@MartinKoeditz MartinKoeditz added the bug Something isn't working label Jan 31, 2023
@MartinKoeditz MartinKoeditz self-assigned this Jan 31, 2023
@Jon4t4n
Copy link
Contributor Author

Jon4t4n commented Feb 4, 2023

It is hard to say if the changes here are causing the CI failures or if the changes in #40 also play a role. But we hit an assert here that we did not hit in the CI run on the previous commit.

Zend/zend_hash.c:2305: zend_hash_internal_pointer_reset_ex: Assertion `(&ht->nInternalPointer != pos || zend_gc_refcount(&(ht)->gc) == 1) || ((ht)->u.flags & (1<<6))

CI: https://github.com/FirebirdSQL/php-firebird/actions/runs/4058233486/jobs/6984923000#step:6:160

(I recommend creating a PR to kick off a CI build before landing commits on master. To prevent the master branch from being in a broken state.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants