-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Instance Domains #324
Comments
Just to confirm this should be a FQDN per project rather than a domain per team |
Would this mean the FQDN would be
|
@cgsmith This is specifically talking about running with the docker or kubernetes container drivers not the localfs. With k8s and docker drivers, the projects run in containers so do not have different port numbers on the host and are all mapped to unique hostnames on a single fixed domain at the moment. This epic is about allow teams to have their own root domain. e.g. team one can have You can not host projects (Node-RED instances) on different paths on a single domain (e.g. |
I have customers that would love to use the FF service but, depend on custom domains to serve their clients. Being able to tie a wildcard SSL to an account would be even better. That way new projects could all be under that domain automatically. |
First pass I see the following points that would need working on
The first 3 items are relatively simple to implement, the last point will need very careful planning and may vary based on host environment. I can see a possible k8s approach, but docker may be different. May be able to make use of letsencrypt to issue individual certs for each project. |
The use case of setting a domain for a team is separate to the original issue which is to set a custom FQDN for a project. The Initial story is just per project not team domains and wildcards |
All the same problems still apply re TLS, the user is probably going to need to supply a certificate for the given domain. I suspect it will be easier to implement at a team level rather than per-project. |
@Pezmc stick a slot in the calendar and we can talk about how this will work. I think most of the work will actually be in the UI/UX apart from working out how to handle the TLS certs. |
Notes:
Pez:
Ben:
|
Current state:
|
Any draft PR or linked issues for this? |
I've updated the description with a task list based on the latest status update. |
Status update from Ben:
Wednesday next week is when Ben hope it'll be rounded off |
I have this working properly in my local K8s environment. Following the change to make the authentication redirect to the right place I will need to add a launcher version check to the UI so it's only offered on new launchers/stacks. |
HTTPS support appears to be working... |
Can I get a status update on this please @hardillb? How are we looking for 2.5 release, or earlier? |
There is a large amount of extra things that will need configuring in the production cluster to enable this, it should be part of the 2.5 release, even once this is merged. |
I'm currently struggling to get the UI to track when the instance is restarted properly. It just gets stuck in the suspended state. Once that is fixed then all the code should be finished. |
Once coding is done, can we open relevant issues (and link back to here) to document outstanding work required to get this live please? |
Can this be closed off now? |
@joepavitt it's only because its being used as the overriding epic for the 2 bits of future work. I can be closed for me. |
Can close this once FlowFuse/terraform-aws-flowfuse#8 is resolved, #3982 will stay open as a follow-on task should the demand for it be there |
Closing as majority of work is done |
Description
As a Team Owner,
I want to be able to supply a custom domain to be used with my projects to differentiate them from other projects hosted on the system
Customer requests
1st Iteration Development Work
Production Updates
Future work
The text was updated successfully, but these errors were encountered: