Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff-kebab-menu missing features #76

Open
Steve-Mcl opened this issue Oct 21, 2022 · 1 comment
Open

ff-kebab-menu missing features #76

Steve-Mcl opened this issue Oct 21, 2022 · 1 comment
Labels
area:frontend For any issues that require work in the frontend/UI

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

It is the intention of removing the headlessui MenuItem (as currently used in the action menu) but in its current form lacks several features e.g. disabling menuitems, keyboard navigation, role and aria attributes, separators etc.

Expected Behavior

as a matter of course, we should implement keyboard navigation and aria / role for accessibility on the menu like the headlessui menu does,

each item in the menu should get a suitable role for screenreaders

As for disabling an item, this could of course be "hacked" (wrapped in a div for example) but supporting the disabled property in the ff-list-item might be more consistent (site wide)

For separators, again this could be manufactured with HTML but feel the kebab menu should have an awareness / support separators O.O.T.B

Steps To Reproduce

See more info in FlowFuse/flowfuse#1114

Environment

  • FlowForge version: 0.10.0-git
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Oct 21, 2022
@knolleary knolleary moved this to Unplanned in ☁️ Product Planning Oct 26, 2022
@joepavitt
Copy link
Collaborator

update to this in that we do now support disabled on ff-list-item in a ff-kebab-menu, see example: https://flowforge.github.io/forge-ui-components/#ff-kebab-menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI
Projects
Status: No status
Development

No branches or pull requests

2 participants