Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between documentation and help text in ui-dropdown #1553

Closed
rucksman opened this issue Dec 21, 2024 · 1 comment · Fixed by #1555
Closed

Difference between documentation and help text in ui-dropdown #1553

rucksman opened this issue Dec 21, 2024 · 1 comment · Fixed by #1555
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@rucksman
Copy link

Current Behavior

The documentation for ui-dropdown states that for dynamic options the syntax should be msg.ui_update.options. Clicking on the "fx" icon in the node itself says one should send msg.options.

Expected Behavior

Documentation and help text in the node itself show show the same - correct - msg format.

Steps To Reproduce

Take a look into documentation and into the node itself

Environment

No response

Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member

@rucksman rucksman added bug Something isn't working needs-triage Needs looking at to decide what to do labels Dec 21, 2024
@bartbutenaers
Copy link
Contributor

That seems to be a leftover from the early days, when the msg.ui_update mechanism wasn't introduced yet.
This pull request should fix it.

@Steve-Mcl Steve-Mcl linked a pull request Dec 22, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Dashboard Backlog Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants