Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKS-2935 Added test coverage the failure outcome in the DeviceSigningVerifier node #389

Merged
merged 3 commits into from
Feb 1, 2024
Merged

SDKS-2935 Added test coverage the failure outcome in the DeviceSigningVerifier node #389

merged 3 commits into from
Feb 1, 2024

Conversation

spetrov
Copy link
Contributor

@spetrov spetrov commented Jan 26, 2024 •
edited
Loading

JIRA Ticket

SDKS-2935: If a user is set to inactive the DeviceSigningVerifier node throws an exception

Description

  • Added test coverage for the Capture Failure option in the Device Signing Verifier node
  • Added test coverage for the DeviceSigningVerifierNode.FAILURE shared state variable

@spetrov spetrov requested a review from witrisna January 26, 2024 02:30
@spetrov spetrov changed the title SDKS-2935 Added test coverage for the "non active" user and non-existing user. SDKS-2935 Added test coverage for "non-active" and "non-existing" users Jan 26, 2024
@spetrov spetrov changed the title SDKS-2935 Added test coverage for "non-active" and "non-existing" users SDKS-2935 Added test coverage the failure outcome in the DeviceSigningVerifier node Jan 31, 2024
witrisna
witrisna previously approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@witrisna witrisna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spetrov spetrov merged commit 37648fb into develop Feb 1, 2024
7 of 8 checks passed
@spetrov spetrov deleted the SDKS-2935 branch February 1, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witrisna witrisna witrisna left review comments

@jeyanthanperiyasamy jeyanthanperiyasamy Awaiting requested review from jeyanthanperiyasamy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spetrov @witrisna