Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-2948 crash fix and improvement #390

Merged
merged 1 commit into from
Feb 5, 2024
Merged

SDKS-2948 crash fix and improvement #390

merged 1 commit into from
Feb 5, 2024

Conversation

jeyanthanperiyasamy
Copy link
Contributor

JIRA Ticket

Please link jira ticket here

Description

Briefly describe the change and any information that would help speedup the review and testing.

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Just need to update the copyright

@jeyanthanperiyasamy
Copy link
Contributor Author

jeyanthanperiyasamy commented Feb 2, 2024

Addressed the comments

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@spetrov spetrov merged commit 552628d into develop Feb 5, 2024
8 of 9 checks passed
@spetrov spetrov deleted the SDKS-2948-Crash branch February 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants