SDKS-2988 Resolve the CVE-2023-52428 issue by upgrading the nimbus-jose-jwt #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witrisna
requested review from
jeyanthanperiyasamy,
rodrigoareis and
spetrov
|
|
||
| override fun apply(project: Project) { | ||
| project.android().apply { | ||
| compileSdk = 34; |
There was a problem hiding this comment.
What do you think about use a constant or property file to avoid the need to change the code directly in a new version?
There was a problem hiding this comment.
It seems not straightforward to use the variable in toml, may consider it in another story.
forgerock-auth-ui/src/main/java/org/forgerock/android/auth/ui/SingleLiveEvent.java
Outdated
Show resolved
Hide resolved
…se-jwt. Other enhancement are included in this PR: 1. Centralize the version in toml file. 2. Refactor Core and Auth module build.gradle file to build.gradle.kts 3. Since the root detector is moved to core, move the jni folder from auth to core. 4. introduce buildSrc to share common configuration. 5. Remove lombok from forgerock-auth-ui and remove doc and build for forgerock-auth-ui
jeyanthanperiyasamy
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-2988
Description
Resolve the CVE-2023-52428 issue by upgrading the nimbus-jose-jwt
Other enhancements are included in this PR: