SDKS-3104 - Improvements in caching the key reference #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| companion object { | ||
| //Hold the current key. | ||
| val keyReferenceCache = AtomicReference<SecretKey>() |
There was a problem hiding this comment.
we are caching the key , once we access the secret reference, so we access the keystore only once
witrisna
requested changes
Apr 16, 2024
|
|
||
| @Throws(GeneralSecurityException::class, IOException::class) | ||
| override fun reset() { | ||
| keyStore.deleteEntry(keyAlias) |
There was a problem hiding this comment.
Shoud we remove the cache also?
There was a problem hiding this comment.
yes good point
jeyanthanperiyasamy
force-pushed
the
SDK-3104
branch
5 times, most recently
from
f617ca0 to
d7991eb
Compare
witrisna
previously approved these changes
Apr 17, 2024
jeyanthanperiyasamy
force-pushed
the
SDK-3104
branch
from
d7991eb to
457bab2
Compare
rodrigoareis
previously approved these changes
Apr 17, 2024
spetrov
previously approved these changes
Apr 24, 2024
spetrov
previously approved these changes
Apr 24, 2024
spetrov
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Please link jira ticket here
Description
Briefly describe the change and any information that would help speedup the review and testing.