Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of atob/btoa #231

Open
christian-brindley opened this issue Jan 10, 2025 · 0 comments
Open

Remove use of atob/btoa #231

christian-brindley opened this issue Jan 10, 2025 · 0 comments

Comments

@christian-brindley
Copy link
Collaborator

We should not be using atob/btoa for base64 decoding/encoding - this causes issues with international character sets. Instead should use

  • Buffer.from(b64string, "base64") for decoding
  • toString("base64") for encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant