You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
I'm a very interested follower of the Radium and Radium-Grid projects of yours.
I love your approach at using the space-between setting for creating the gutter, even though I somehow don't like the fact that it will only work if the Cells add up to a width of 1 for each wrapped line. And detecting line breaks to fill those gaps automatically with e.g. margins would require large amounts of logic involving the order property, given sizes etc., effectively reverse-engineering a fair part of the flexbox placement logic.
That's why I have two questions:
Is there a specific reason why you chose to use the rather dynamic and unreliable space-between setting instead of e.g. center or flex-start/-end along with margins? After all, you do render a div per Cell anyways, so why not give it half a gutter as margin per side and make the gutter width adapt to the breakpoints? Even if the reason is that you don't want to have that half gutter before the first or after the last column (which is a common requirement on the other hand), you could easily remove that again using negative margin on the Grid component, which is also entirely under your control.
Did you ever try to build a grid using higher-order components or decorators to avoid having too many layers of divs within the dom? I'm also a huge supporter of fighting all those unnecessary row, wrapper, container etc. divs in favor of trying to accomplish everything with one flex-container and its flex-items as children.
I would be really happy if you could give me your thoughts on those questions. Or maybe hint me towards a mailing list or discussion going on somewhere where people had the same ideas.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm a very interested follower of the Radium and Radium-Grid projects of yours.
I love your approach at using the space-between setting for creating the gutter, even though I somehow don't like the fact that it will only work if the Cells add up to a width of 1 for each wrapped line. And detecting line breaks to fill those gaps automatically with e.g. margins would require large amounts of logic involving the order property, given sizes etc., effectively reverse-engineering a fair part of the flexbox placement logic.
That's why I have two questions:
I would be really happy if you could give me your thoughts on those questions. Or maybe hint me towards a mailing list or discussion going on somewhere where people had the same ideas.
The text was updated successfully, but these errors were encountered: