Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryPie animation stop with wrong values #2991

Closed
2 tasks done
berthoug opened this issue Nov 29, 2024 · 1 comment
Closed
2 tasks done

VictoryPie animation stop with wrong values #2991

berthoug opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@berthoug
Copy link

berthoug commented Nov 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

37.3.2 (the issue is not present in 36.6.11, but present in 36.9.2 and still present in 37.3.2)

Code Sandbox link

https://codesandbox.io/p/sandbox/piechart-zzgrtl

Bug report

When changing the amount of data and their value in a victory pie the animation ends with a pie in a state that suggests that it took in account the removal of some entries, but not the change of values.

Steps to reproduce

- create a pie chart and set the data to `[1, 1, 1, 1, 5]`
- update the data to be `[9, 1, 1, 1]` (in the sandbox, click on the update button)

Expected behavior

The animation should end with a pie chart showing four districts, one of which is nine times the size of the others.
Screenshot 2024-11-29 at 13 43 25

Actual behavior

The animation ends up with a pi chart with four equal districts.
Screenshot 2024-11-29 at 13 36 47

Environment

- Device: laptop
- OS: macos 14.6.1
- Node:v21.6.2
- npm:10.2.4
@berthoug berthoug added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Nov 29, 2024
@djm158 djm158 self-assigned this Dec 10, 2024
@djm158 djm158 mentioned this issue Dec 12, 2024
9 tasks
@djm158
Copy link
Contributor

djm158 commented Dec 13, 2024

This looks like a duplicate of #531

I did leave some notes as to why this specific issue is occurring in the linked PR, but I think we can close this in favor of #2104

@djm158 djm158 closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

2 participants