Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load local lyrics from .txt files #102

Closed
6 of 7 tasks
lucas-mior opened this issue Oct 29, 2024 · 3 comments
Closed
6 of 7 tasks

Load local lyrics from .txt files #102

lucas-mior opened this issue Oct 29, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@lucas-mior
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Be able to display lyrics from txt file with the same name as the music file.

Why do you want this feature?

I already have most of my music with lyrics (thanks to ncmpcpp) in txt files.
Unfortunately, android makes it extremely painful to open any app that shows txt contents, and even if it wasn't, they would not be synced with the current music that is playing.

Additional information

Related to VinylMusicPlayer/VinylMusicPlayer#816

@lucas-mior lucas-mior added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 29, 2024
@Aga-C
Copy link
Member

Aga-C commented Oct 30, 2024

It's a duplicate of #39.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
@Aga-C Aga-C added duplicate This issue or pull request already exists and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 30, 2024
@lucas-mior
Copy link
Author

It is not a duplicate. #39 is about synced lyrics (.lrc format).
This one is about plain text lyrics, which should be much simpler to implement.

@Aga-C
Copy link
Member

Aga-C commented Oct 30, 2024

We have no lyrics support at all, so I don't see a reason to keep two separate requests for simpler and more advanced implementation of basically the same feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants