-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a keepMounted
option
#87
Comments
This is related to caching. |
Hi! I really really need that feature, how can i help? |
@dientuki Hi, sorry for a late response, I actually wanted to work on this feature when new React Visibility API is fully there. But we can start working on it now. What we need is to make sure the component is mounted while not visible, we can probably use But this feature will be a breaking change since, it makes ANY component to be always mounted, so I believe we should set
Hope this helps, I'm currently busy with other staff, so hope you'll figure out how to implement this yourself. I will try to review the PR ASAP. |
Related to #258 |
Motivation
By default, all modals continue to be mounted even when they are closed. Despite of that it's giving some advantages, sometimes it may be required to unmount it.
For example, the modal can contain a state machine that will continue working after closure, which may be unintentional.
Description
keepMounted
will be added toModalParams
, so developers can disable it for single modal or all modals by default.Example 1
Example 2
These two modals will have the same behavior.
The text was updated successfully, but these errors were encountered: