Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[♻️ refactor] Use cmdk for the action-list component #58

Open
1 task done
Fredkiss3 opened this issue Sep 18, 2023 · 1 comment
Open
1 task done

[♻️ refactor] Use cmdk for the action-list component #58

Fredkiss3 opened this issue Sep 18, 2023 · 1 comment
Labels
refactor code cleanup

Comments

@Fredkiss3
Copy link
Owner

Fredkiss3 commented Sep 18, 2023

What is the reason to do this refactor ?.

To improve accessibility and navigation with keyboard on that component

Describe the work that needs to be done

Need to change the action-list input with cmdk input. And do the rest...

Additional context

We can tweak the use-item-grid hook i used here to do this and instead of passing every item group, we pass a function to get an item at a certain position in the list.

  • Are you willing to make a PR for this ?
@Fredkiss3 Fredkiss3 added need-triage This issue needs confirmation refactor code cleanup and removed need-triage This issue needs confirmation labels Sep 18, 2023
@Fredkiss3 Fredkiss3 moved this to Todo in Gh-next Sep 30, 2023
@Fredkiss3 Fredkiss3 removed the status in Gh-next Oct 17, 2023
@Fredkiss3 Fredkiss3 moved this to In Progress in Gh-next Nov 19, 2023
@Fredkiss3 Fredkiss3 moved this from In Progress to Todo in Gh-next Nov 20, 2023
@Fredkiss3
Copy link
Owner Author

won't do, too annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code cleanup
Projects
Status: Todo
Development

No branches or pull requests

1 participant