Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Disabling spell check #6548

Open
3 tasks done
PietJanHein opened this issue Jan 11, 2025 · 4 comments · May be fixed by #6599
Open
3 tasks done

[Feature Request]: Disabling spell check #6548

PietJanHein opened this issue Jan 11, 2025 · 4 comments · May be fixed by #6599

Comments

@PietJanHein
Copy link

PietJanHein commented Jan 11, 2025

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

As far as I can see there is no option in FreeTube yet to disable the spell check from Chromium. This spell check is not active when you use the search bar in the top, but unfortunately it is active when you search within a YouTube channel itself. See the screenshot. In my experience spell check mostly gets in the way while it doesn't help. For example, it will point out that "linux" is wrong because Linux is a name. Fair enough, but the user doesn't care about spelling it wrong at that moment because it doesn't make a difference for the search result (case-insensitive search) and it takes less effort to not capitalize the name. In other cases the spellcheck simply does't know a name or word, or the user uses another language which might it might not have the dictionary for. Red lines reduce the readability and in my opinion it looks ugly.

Proposed Solution

2 options:

  1. fully disable the spellcheck for this Electron-app
  2. build in a toggle to turn it on or off, in case this option is chosen and it is not being done automatically based on the set language of the user then it should also allow the user to switch to another language which makes the app more bloated because dictionaries have to be added for those languages (if this is not already the case).

Alternatives Considered

I looked up if I could disable spellcheck for electron in general, I haven't found a solution.

Issue Labels

ease of use improvement, new feature, visual improvement

Additional Information

image

@kommunarr
Copy link
Collaborator

There's this, but it can also be done by setting the spellcheck property on our custom input elements.

@PietJanHein
Copy link
Author

There's this, but it can also be done by setting the spellcheck property on our custom input elements.

Thanks for helping me, I can program a bit (C/C++/Rust/C#) but I am rather incompetent with Chromium-browsers, I always used Firefox. In Firefox I could type about:config in the addressbar and probably then set a value for a variable which is used for that, is the process in Chromium similar?

@kommunarr
Copy link
Collaborator

To clarify, I'm talking about if someone wants to implement the fix in the official repo.

@kommunarr kommunarr added the good first issue Good for newcomers label Jan 11, 2025
@kommunarr kommunarr changed the title [Feature Request]: disabling spell check or building in an option in the GUI to either disable or enable it and change the language [Feature Request]: Disabling spell check Jan 11, 2025
@SudharakaP
Copy link

SudharakaP commented Jan 17, 2025

@kommunarr : I can make a fix for this. I just did using the first method you suggested.

@SudharakaP SudharakaP linked a pull request Jan 17, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

Successfully merging a pull request may close this issue.

3 participants