Correctly Show View Count for Video when there is Zero Views #6596
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
6 tasks
|
Please change it in the local API parsing not in the display code. If we know that there are zero views we should show 0 views, we only hide stuff when the information is not available (e.g. published dates on the channel shorts tab). |
absidue
added
PR: changes requested
and removed
PR: waiting for review
SudharakaP
changed the title
auto-merge was automatically disabled
January 16, 2025 20:55
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
January 16, 2025 20:59
Head branch was pushed to by a user without write access
SudharakaP
force-pushed
the
fix/do-not-show-view-count-when-zero
branch
from
a9d4063 to
b57f44c
Compare
@absidue : Done, let me know if you see any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Correctly Show View Count for Video when there is Zero Views
Pull Request Type
Related issue
Resolve #6568
Description
This PR solve the issue of showing
NaN Viewswhen there's zero view count for a videoScreenshots