Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end tests are difficult to enable #88

Open
glebec opened this issue Oct 10, 2016 · 0 comments
Open

Front-end tests are difficult to enable #88

glebec opened this issue Oct 10, 2016 · 0 comments

Comments

@glebec
Copy link
Member

glebec commented Oct 10, 2016

FSG by default loads the home state upon initialization. This makes it difficult to unit test components. To have working front-end tests, students must either:

  • Architect all their services as belonging to a standalone Angular module, à la fsgPrebuilt.
  • Use a preprocessor and accept that the home state + all its dependencies are going to be bootstrapped (bad idea)
  • Add a testing harness that detects the node environment, sets some window flags, and configures the app accordingly (probably the easiest).

This is, of course, specific to Angular and we are probably going to abandon Angular-FSG for React-FSG. However if we continue to use the Angular version of this app, we should probably implement the third option above to make it easier on students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant