Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxPartialSound does not work properly in iOS #3

Open
moondroidcoder opened this issue Jun 21, 2024 · 0 comments
Open

FlxPartialSound does not work properly in iOS #3

moondroidcoder opened this issue Jun 21, 2024 · 0 comments

Comments

@moondroidcoder
Copy link
Contributor

This pull-request #2 fixes polymod implementation for FlxPartialSound, it also is supposed to fix mobile implementation.
The (now reverted) commit c3dffed is supposed to fix issues with iOS platforms not being able to load freeplay audio.

But because it was reverted, there's an issue that popped up. iOS Native can't play base-game audio anymore on funkin, but mods (zipped or not) work with no problems.

iOS Footage for the base game:

RPReplay_Final1718977303.mov

iOS Footage for base game w/ mods:

RPReplay_Final1718986078.mov

Since iOS is really similar to Android, i think it's worth to mention that android functions flawlessly with the current implementation. Mods, zip mods, and base game audio were all loaded and played correctly.

Android Footage:

screen-20240621-171324.mp4

I think this is a fairly easy fix since unreverting the commit practically fixes everything! We tested it with our own fork.

@moondroidcoder moondroidcoder changed the title FlxPartialSound does not work in iOS FlxPartialSound does not work properly in iOS Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant