-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: Song may restart at the end, meanwhile missed notes pass by #3142
Comments
I managed to reproduce this bug back in v0.4.1, but I simply thought it was an issue with one of my mods. |
Definitely looking for help diagnosing/reproducing this. |
I was encountering the same issue but can only reproduce it on web. I also use firefox. |
Yeah I was trying it on the standalone build but couldn't reproduce it. Could be a browser / web version specific issue. |
I also had managed to reproduce it in that version while I was testing #2706, but I was on WSL and couldn't replicate it again afterward. |
Encountered this one at the end of Cocoa Erect on itch.io Web. |
Were you perchance in Firefox as well? |
I was using Brave when this happened |
Had this exact same thing happen to me on both DadBattle Pico & Blammed Pico Opera GX, btw |
Had this issue happen to me in the windows build during my first time playing Pico (Pico Mix). |
Just replicated this bug with Bopeebo (Pico Mix) on itch.io for Brave. The clip begins on the second loop of the song and goes into the third loop (which starts in the middle of the song). Pico.ghost.loop.bug.mp4 |
I also had this happen to me whilst playing South (Pico Mix) on Newgrounds, also on Firefox. I think the ghost notes are notes you missed the first time round and they're just wrapping round the second time. |
I've observed this "wrapping around" effect as well! |
I literally can't complete Philly Nice (Pico Mix) and Blammed (Pico Mix) because of this issue |
This can be happen in windows build too, just rarely unless framerate are unlocked it somehow increases the chances of it happening |
Got this bug as well while playing 2Hot on the itch.io version, as well as while playing on the web version (using Microsoft Edge). I think this might happen is because Conductor sets the song position to 0.0 if FlxG.sound.music is null, which also restarts the song in PlayState's stepHit() function. Not sure why onComplete doesn't want to work for FlxG.sound.music, but if I find sumthin I'll edit da comment more. |
I experienced the same thing on Chrome |
Apparently it's easier to reproduce this issue if Unlocked Framerate is enabled, and doesn't seem to occur when it's disabled. |
i have found multiple ways to reproduce this looping bug. |
This just happened to me moments ago. I was playing South on Hard in Story Mode, and when the song finished it didn't end but the song replayed and ghost notes passed by. I believe those notes might be the notes I missed before the song looped? But my game broke and the sprites became black after finishing the looped song. I'm on Opera Gx playing on Newgrounds btw |
Woohoo! |
RIP this issue, it was a good run 🫡 |
@EliteMasterEric |
I think it should be pinned until 0.6.0 comes out and fixes it! |
Yeah I just got this issue today actually- it didn't infinitely loop, just played one more time. Only one ghost note passed. 0201.1.mp4Bopeebo Pico remix, playing as Pico. Version 0.5.3, Microsoft Edge, played on Newgrounds. At the time of posting this I for some reason didn't see it was resolved my bad :,) |
The issue seems to be fixed in the develop branch. I recommend compiling it and playing on that build to avoid the bug. |
I wonder if this issue is related to this #4155 one somehow? Seeing how they're of similar things (the conductor getting ahead of the music, vs the music going back in time slightly when the playback speed is 0.5 or lower) |
Reopening this issue because the author provided more information. |
Oops, I forgot the bot does that. |
Issue Checklist
What platform are you using?
Itch.io (Web)
If you are playing on a browser, which one are you using?
Firefox
Version
0.5.0
Context (Provide images, videos, etc.)
After a song ends, it might repeat once more. While this is happening "ghost" notes pass by.
Edit: In certain cases it seems like it'll keep repeating from where you last paused and basically getting you stuck unless you don't keep pausing and unpausing.
8mb.video-V09-1X6W5zzk.mp4
Steps to reproduce (or crash logs, errors, etc.)
This might not always happen and seems to occur more frequently on web builds when using Unlocked Framerate, but it is not necessarily caused by it.
The text was updated successfully, but these errors were encountered: