Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make only long hold notes have transparency #4070

Closed
3 tasks done
Lasercar opened this issue Jan 31, 2025 · 2 comments
Closed
3 tasks done

Enhancement: Make only long hold notes have transparency #4070

Lasercar opened this issue Jan 31, 2025 · 2 comments
Labels
status: rejected Issue did not pass review or PR cannot be approved. type: enhancement Involves an enhancement or new feature.

Comments

@Lasercar
Copy link
Contributor

Lasercar commented Jan 31, 2025

Issue Checklist

  • I have read the pinned Issues Guide
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
  • I have properly named my enhancement

What is your suggestion, and why should it be implemented?

When I was getting some clips for this PR FunkinCrew/funkin.assets#111 a few days ago, I thought that transparent hold notes looked way cooler than opaque ones.

If the issue is that short hold notes are harder to see with the transparency, then maybe only make short holds opaque, but make everything else have the transparency? Something like this:
Screenshot 2025-01-29 162941
The only problem really with doing it like this is that it doesn't really account for scroll speeds (and it might effect song loading performance? idk), but I'm sure something can be figured out for that too

@Lasercar Lasercar added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 31, 2025
@EliteMasterEric
Copy link
Member

I think it would be way weirder if different hold durations had different levels of opacity.

@EliteMasterEric EliteMasterEric added status: rejected Issue did not pass review or PR cannot be approved. and removed status: pending triage Awaiting review. labels Feb 17, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 17, 2025

Ah, ok. I still think it’d be great for parts with lots of long hold notes, as they now cover up your character and everything. It just doesn’t look that nice as it is right now.

Play-through senpai with the change, and then without the change and you’ll see what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

2 participants