Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #56 Change title from 'React App' to 'GDSC ITM' #60

Merged
merged 3 commits into from
Mar 13, 2023
Merged

fix: #56 Change title from 'React App' to 'GDSC ITM' #60

merged 3 commits into from
Mar 13, 2023

Conversation

PalakJain9
Copy link
Contributor

I've changed the website's title from the default 'React App' to 'GDSC ITM'.
Kindly review my PR.

@welcome
Copy link

welcome bot commented Mar 12, 2023

💖 Thanks for opening this pull request! 💖

Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of Title with semantic prefixes:

  • fix: If PR is about fixing a problem
  • feature: If Pr is about adding feature
  • docs: If PR is about docs

Things that will help get your PR across the finish line:

  • Include screenshots and animated GIFs whenever possible.

@netlify
Copy link

netlify bot commented Mar 12, 2023 •
edited
Loading

✅ Deploy Preview for gdscitm ready!

Name Link
🔨 Latest commit 463b178
🔍 Latest deploy log https://app.netlify.com/sites/gdscitm/deploys/640f5049605d6c0007d0e29b
😎 Deploy Preview https://deploy-preview-60--gdscitm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot]
github-actions bot reviewed Mar 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for submitting a pull request! We're excited to review your contribution and see how it can improve the project. Let us know if you have any questions or concerns. Thanks again for your help!

@PalakJain9 PalakJain9 changed the title Fixes #56: Change title from 'React App' to 'GDSC ITM' fix: #56 Change title from 'React App' to 'GDSC ITM' Mar 12, 2023
@ArunPatel02 ArunPatel02 linked an issue Mar 12, 2023 that may be closed by this pull request
🐛 Bug Report: Change title from 'React App' to 'GDSC ITM' #56
Closed
1 task
ArunPatel02
ArunPatel02 previously approved these changes Mar 12, 2023
View reviewed changes
Yashsharma1911
Yashsharma1911 requested changes Mar 12, 2023
View reviewed changes
Copy link
Member

@Yashsharma1911 Yashsharma1911 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @PalakJain9 👏 as you are there can you do one more thing, we also need to replace that react icon with GDSC logo that would be helpful

Screenshot 2023-03-12 at 2 48 32 PM

@PalakJain9
Copy link
Contributor Author

Sure @Yashsharma1911 , working on it

@Yashsharma1911 Yashsharma1911 added area/website issue or pr is for website component/ui issue or pr is for UI labels Mar 12, 2023
@PalakJain9
Copy link
Contributor Author

Hey, I haven't dismissed any review nor have I chosen any other option, yet I see the message of dismissing ArunPatel02's review. What could be the possible reason?

@ArunPatel02
Copy link
Member

463b178

@PalakJain9 the reason behind this is pr update . when you pushed commit 463b178 your pr got updated with current commit and that will automatically dismissed previous approval. it is one of the feature of GitHub you haven't dismissed any reviews.

ArunPatel02
ArunPatel02 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@ArunPatel02 ArunPatel02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @PalakJain9 you have done a wonderful job👍👍

@ArunPatel02 ArunPatel02 merged commit 27e068e into GDSCITM:main Mar 13, 2023
@welcome
Copy link

welcome bot commented Mar 13, 2023

Congrats on merging your first pull request! 🎉🎉🎉
cat meme

@PalakJain9
Copy link
Contributor Author

Thanks @ArunPatel02 @Yashsharma1911 for your support and cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Yashsharma1911 Yashsharma1911 Yashsharma1911 requested changes

@ArunPatel02 ArunPatel02 ArunPatel02 approved these changes

Assignees
No one assigned
Labels
area/website issue or pr is for website component/ui issue or pr is for UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Change title from 'React App' to 'GDSC ITM'
3 participants
@PalakJain9 @ArunPatel02 @Yashsharma1911