Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in CHANGELOG #289

Open
tclune opened this issue Sep 13, 2024 · 0 comments
Open

Bug in CHANGELOG #289

tclune opened this issue Sep 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tclune
Copy link
Contributor

tclune commented Sep 13, 2024

The following line was added in the ADDED section of the GOCART Changelog (unrleased)

Changed SU2G_instance_SU.rc to now have separate filename inputs for explosive and degassing volcanoes

It would be better if this line was put into the CHANGED section. External users should always check the CHANGED section when upgrading and it therefore more visible/important.
@tclune tclune added the bug Something isn't working label Sep 13, 2024
tclune added a commit that referenced this issue Sep 13, 2024
@tclune
Fixes #289 Correct CHANGELOG.md
a5f4cc2 
Moved "change" from "ADDED" to "CHANGED" section of CHANGELOG.
vbuchard added a commit that referenced this issue Sep 27, 2024
@vbuchard
Merge pull request #290 from GEOS-ESM/tclune-patch-1
ffa44c7 
Fixes #289 Correct CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune