Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKdopa2-OH does not build on test #172

Open
holmess2013 opened this issue Oct 28, 2024 · 5 comments
Open

DKdopa2-OH does not build on test #172

holmess2013 opened this issue Oct 28, 2024 · 5 comments
Assignees
Labels

Comments

@holmess2013
Copy link

If you just click the Kdo button on the carb builder on test and hit done, the attached error message is shown.
Kdo_bug

@gitoliver
Copy link
Contributor

@danwentworthart when I click these buttons in the website it should be injecting the string "KDN" or "KDO" not "Kdn" and "Kdo". The metadata I sent you has KDN and KDO so check where this error crept in.

If you build DKDNpa2-OH in build via text you get a 3D structure.

@danwentworthart
Copy link
Contributor

Ah. I edited the name to match the filename, because that is how they are looked up. I will see about editing both. I think Preston was talking about consolidating and having these maintained in gmml or something. Not sure if he did that yet, but it will be useful to know that the filenames and residue names are used in this way.

@danwentworthart
Copy link
Contributor

Fixed in commit 1ca496c9c20a502965dec557485d380fc3fc252b
Not yet distributed.

@gitoliver
Copy link
Contributor

Having the filenames match is a good idea, but let's get this fixed and tested before doing that change.

@danwentworthart
Copy link
Contributor

That did fix it. The data gives me a name, I append the name of the residue to a path. This is how the file is used. Same string gives the inserted text. You would need separate fields if you wanted a filename separate from the inserted text, but don't do any work, I fixed it. I have a copy of the files you created up in the staticfiles for the site. This is what I renamed. The files you created in GMML are unchanged.
I mentioned Preston's intentions because any file renaming will break the link between the fixturedata/js that loads/ and the file being loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants