Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running pointings don't count for retraction notice #74

Closed
martinjohndyer opened this issue Aug 10, 2023 · 1 comment
Closed

Running pointings don't count for retraction notice #74

martinjohndyer opened this issue Aug 10, 2023 · 1 comment
Labels
-event_handler Issues/PRs related to the event handler bug Issues detailing a bug or error within the software

Comments

@martinjohndyer
Copy link
Member

retraction

The reason this event had 2 "pending" pointings remaining is because GOTO-3 and GOTO-4 were observing them. We intentially don't want to remove running pointings even if an event is retracted, because we might as well let them finish. So the sentinel worked as intended, it's the Slack alert that needs to be changed to not complain if the leftover pointings are still running.
@martinjohndyer martinjohndyer added -effort 3 bug Issues detailing a bug or error within the software -event_handler Issues/PRs related to the event handler labels Aug 10, 2023
@martinjohndyer
Copy link
Member Author

Fixed in #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-event_handler Issues/PRs related to the event handler bug Issues detailing a bug or error within the software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinjohndyer