Fitting Peaks

[cnatzke]

Is TPeakFitter still the preferred method for fitting peaks? E.g.

TPeakFitter *pf = new TPeakFitter(lowFit, highFit);
TRWPeak *peak = new TRWPeak(peakPos);

// using initial Guess
peak->GetFitFunction()->SetParameter(1, peakPos);
peak->GetFitFunction()->SetParameter(2, 1.0);

pf->AddPeak(peak);
pf->Fit(inputHist, "L");

[VinzenzBildstein]

Yes, that is still the newest and preferred method.

[cnatzke]

Sounds good. I just wanted to double check.

On a related note, I'm trying to compile a fitting routine against GRSISort that uses the TPeakFitter class. I'm getting the error

[100%] Linking CXX executable GenerateDistribution
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libTPeakFitting.so: undefined reference to `TGRSIFunctions::CheckParameterErrors(TFitResultPtr const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/GenerateDistribution.dir/build.make:129: GenerateDistribution] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/GenerateDistribution.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

I'm using cmake and the code is located here.

I think the issue is the order in how the libraries are linked. Do you have any suggestions?

[VinzenzBildstein]

Can you make cmake show you the actual linking command it uses? I think you can either use make VERBOSE=1 or -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON and then a normal make.

But looking at the libraries that I have (using nm <library> | grep CheckParameterErrors) shows that this is only defined in libTGRSIFit.so, libTAnalysis.so, and libGRSI.so, but isn't defined in libTPeakFitting.so or libGROOT.so.

[cnatzke]

[ 20%] Linking CXX executable GenerateDistribution
/usr/bin/cmake -E cmake_link_script CMakeFiles/GenerateDistribution.dir/link.txt --verbose=1
g++  -Wall -O3   -std=c++14 -pipe -fsigned-char -pthread  -std=c++14 -pipe -fsigned-char -pthread -pedantic -Wno-long-long -g -g  -rdynamic CMakeFiles/GenerateDistribution.dir/src/DistributionManager.cpp.o CMakeFiles/GenerateDistribution.dir/src/FitManager.cpp.o CMakeFiles/GenerateDistribution.dir/src/GenerateDistribution.cpp.o CMakeFiles/GenerateDistribution.dir/src/HistogramManager.cpp.o  -o GenerateDistribution   -L/home/cnatzke/programs/cern/root/v6.26.04/lib  -Wl,-rpath,/home/cnatzke/programs/cern/root/v6.26.04/lib: -L/home/cnatzke/programs/griffin-collaboration/GRSISort/lib -lTDetector -lTGRSIint -lTFormat -lTGRSIint -lTFormat -lTLoops -lTKinematics -lTSRIM -lTBetaDecay -lTCal -lTReaction -lTSuppressed -lTBgo -lTPulseAnalyzer -lGROOT -lTGRSIFit -lTNucleus -lTRawFile -lTDataParser -lTHistogramming -lXMLParser -lXMLIO -lX11 -lXpm -lProof -lGuiHtml -lMinuit -lSpectrum -lMathMore -L/home/cnatzke/programs/griffin-collaboration/GRSISort/GRSIData/lib -lTAngularCorrelation -lTCSM -lTDescant -lTGRSIDataParser -lTGRSIFormat -lTGenericDetector -lTGriffin -lTLaBr -lTMidas -lTPaces -lTRF -lTS3 -lTSceptar -lTSharc -lTSiLi -lTTAC -lTTigress -lTTip -lTTriFoil -lTZeroDegree -lTEmma -lTTrific -pthread -std=c++14 -m64 -I/home/cnatzke/programs/cern/root/v6.26.04/include -L/home/cnatzke/programs/cern/root/v6.26.04/lib -lCore -lImt -lRIO -lNet -lHist -lGraf -lGraf3d -lGpad -lROOTVecOps -lTree -lTreePlayer -lRint -lPostscript -lMatrix -lPhysics -lMathCore -lThread -lMultiProc -lROOTDataFrame -Wl,-rpath,/home/cnatzke/programs/cern/root/v6.26.04/lib -pthread -lm -ldl -rdynamic -lPhysics -lSpectrum -lTPeakFitting
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libTPeakFitting.so: undefined reference to `TGRSIFunctions::CheckParameterErrors(TFitResultPtr const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/GenerateDistribution.dir/build.make:129: GenerateDistribution] Error 1
make[2]: Leaving directory '/home/cnatzke/projects/two-photon-decay/simulations/ggac/source/make_ggac_distribution/build'
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/GenerateDistribution.dir/all] Error 2
make[1]: Leaving directory '/home/cnatzke/projects/two-photon-decay/simulations/ggac/source/make_ggac_distribution/build'
make: *** [Makefile:130: all] Error 2

I did have to add -lTPeakFitting to the compile command otherwise I get the error:

/usr/bin/ld: CMakeFiles/GenerateDistribution.dir/src/FitManager.cpp.o: in function `FitManager::FitPeak(TH1D*, float, float, float)':
/home/cnatzke/projects/two-photon-decay/simulations/ggac/source/make_ggac_distribution/src/FitManager.cpp:122: undefined reference to `TPeakFitter::TPeakFitter(double const&, double const&)'
/usr/bin/ld: /home/cnatzke/projects/two-photon-decay/simulations/ggac/source/make_ggac_distribution/src/FitManager.cpp:123: undefined reference to `TRWPeak::TRWPeak(double)'
/usr/bin/ld: /home/cnatzke/projects/two-photon-decay/simulations/ggac/source/make_ggac_distribution/src/FitManager.cpp:130: undefined reference to `TPeakFitter::Fit(TH1*, char const*)'
collect2: error: ld returned 1 exit status

[VinzenzBildstein]

I'm assuming you use something like grsi-config --libs to get all those libraries? Could you try using -lGRSI instead (w/o -lTPeakFitting either)?

[cnatzke]

These are the commands I used to get those libraries:

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --all-libs --GRSIData-libs --root
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# linking libraries
target_link_libraries(GenerateDistribution PUBLIC
   ${GRSI_CONFIG}
)

Should it be

# linking libraries
target_link_libraries(GenerateDistribution PUBLIC
   -lGRSI
)

instead?

[VinzenzBildstein]

try using

execute_process(COMMAND grsi-config --GRSIData-libs --root
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

target_link_libraries(GenerateDistribution PUBLIC
   ${GRSI_CONFIG}
)

and replace the -lTPeakFitting that you have somewhere else (?) with -lGRSI

[cnatzke]

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --GRSIData-libs --root
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# Add fitting libraries
set(GRSI_CONFIG "${GRSI_CONFIG} -lGRSI")

I get the error

/usr/bin/ld: cannot find -lGRSI
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/GenerateDistribution.dir/build.make:129: GenerateDistribution] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/GenerateDistribution.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[VinzenzBildstein]

Oh, right. You'll need to add a -L<$GRSISYS>/lib flag as well that point to the location where all the shared object libraries of GRSISort are stored (you might not be able to use $GRSISYS as such, which is why I put it in <>).

[cnatzke]

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --GRSIData-libs --root
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# Add fitting libraries
set(GRSI_CONFIG "${GRSI_CONFIG} -L$ENV{GRSISYS}/lib -lGRSI")

returns errors:

/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::GetChisquare()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Echo(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSetForeground'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XCreateSimpleWindow'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TGHtmlBrowser::TGHtmlBrowser(char const*, TGWindow const*, unsigned int, unsigned int)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::GetTreeHeader(TDSet*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XOpenDisplay'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::DrawSelect(TDSet*, char const*, char const*, char const*, long long, long long)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XFlush'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XGetGeometry'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::MakePlayer(char const*, TSocket*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::GetStagingStatusDataSet(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::AssignData(int, int, double*, double*, double*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XFreePixmap'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XCreatePixmap'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(char const*, char const*, char const*, long long, long long, TObject*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSync'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XFreeFont'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XChangeWindowAttributes'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::GetListOfQueries(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::CancelStagingDataSet(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ShowData()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ClearCache(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XCreateGC'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Echo(TObject const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ShowDataSetCache(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::TProof()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XDefaultScreenOfDisplay'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::PollForNewWorkers()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XpmGetErrorString'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::StartSlaves(bool)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::RequestStagingDataSet(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::SendInputDataFile()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XUnmapWindow'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `typeinfo for TProof'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XLoadQueryFont'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::GetDataSets(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TSpectrum::Search(TH1 const*, double, char const*, double)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::FindUniqueSlaves()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSetClipMask'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(TFileCollection*, char const*, char const*, long long, long long)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XCopyArea'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TSpectrum::~TSpectrum()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Print(char const*) const'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XFreeGC'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::Eval()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::RegisterDataSet(char const*, TFileCollection*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XDrawString'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `ROOT::Math::legendre(unsigned int, double)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Load(char const*, bool, bool, TList*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::~TProof()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Browse(TBrowser*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XTextWidth'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(char const*, long long, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::SaveWorkerInfo()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::~TLinearFitter()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XpmReadFileToPixmap'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ShowStagingStatusDataSet(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ShowCache(bool)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TSpectrum::StaticSearch(TH1 const*, double, char const*, double)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XMoveResizeWindow'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::TLinearFitter(int, char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XDestroyWindow'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::SetAlias(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSetBackground'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::SetDataSetTreeName(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XGetWindowAttributes'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(char const*, TSelector*, char const*, long long, long long, TObject*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ValidateDSet(TDSet*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::GetDataSet(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ShowDataSets(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::VerifyDataSet(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XFillRectangle'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ExistsDataSet(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TSpectrum::TSpectrum()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(TDSet*, char const*, char const*, long long, long long)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XpmFreeAttributes'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSetFont'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XMapRaised'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::ClearDataSetCache(char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TLinearFitter::ClearPoints()'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSelectInput'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(TDSet*, TSelector*, char const*, long long, long long)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(TFileCollection*, TSelector*, char const*, long long, long long)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::RemoveDataSet(char const*, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `TProof::Process(TSelector*, long long, char const*)'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XCloseDisplay'
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libGRSI.so: undefined reference to `XSetClipRectangles'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/GenerateDistribution.dir/build.make:129: GenerateDistribution] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/GenerateDistribution.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[cnatzke]

I changed the linking order around and got the program to compile. I used

# Connect GRSISORT headers
set(GRSI_INCLUDE_DIRS $ENV{GRSISYS}/include $ENV{GRSISYS}/GRSIData/include)

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --all-libs --GRSIData-libs --root 
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# Add fitting libraries
set(GRSI_CONFIG "-L$ENV{GRSISYS}/lib -lTPeakFitting -lGRSI ${GRSI_CONFIG}")

and when running the program I get the error

./GenerateDistribution: error while loading shared libraries: lib.so: cannot open shared object file: No such file or directory

This seems like a completely generic library? I am very confused as to why this compilation is so difficult.

I would expect that the TGRSIFit library contains the necessary classes for TPeakFitter but that doesn't seem to be the case.

[cnatzke]

Removing "-lGRSI" from the cmake command returns the following error:

# Connect GRSISORT headers
set(GRSI_INCLUDE_DIRS $ENV{GRSISYS}/include $ENV{GRSISYS}/GRSIData/include)

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --all-libs --GRSIData-libs --root 
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# Add fitting libraries
set(GRSI_CONFIG "-L$ENV{GRSISYS} -lTPeakFitting ${GRSI_CONFIG}")

[100%] Linking CXX executable GenerateDistribution
/usr/bin/ld: /home/cnatzke/programs/griffin-collaboration/GRSISort/lib/libTGRSIFit.so: undefined reference to `GCanvas::GCanvas(bool)'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/GenerateDistribution.dir/build.make:129: GenerateDistribution] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/GenerateDistribution.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[cnatzke]

I think I finally got it. Here are the cmake commands that finally worked:

# Connect GRSISORT headers
set(GRSI_INCLUDE_DIRS $ENV{GRSISYS}/include $ENV{GRSISYS}/GRSIData/include)

# Grsisort libraries for linking
execute_process(COMMAND grsi-config --all-libs --GRSIData-libs --root 
   OUTPUT_VARIABLE GRSI_CONFIG
   OUTPUT_STRIP_TRAILING_WHITESPACE
)

# Add fitting libraries
set(GRSI_CONFIG "-L$ENV{GRSISYS} -lTPeakFitting -lTGRSIFit -lGROOT ${GRSI_CONFIG}")

An alternative to relinking the TGRSIFit and GROOT libraries was changing the detlibs variable in grsi-config to include the TPeakFitting library.

detlibs="-lTSuppressed -lTBgo -lTPulseAnalyzer -lTPeakFitting -lTGRSIFit -lGROOT -lTNucleus"

It is important to note that the linking order is very specific and deviating from it cause compilation issues.

I am not sure if this is a useful change for grsi-config in the main branch.

[VinzenzBildstein]

Okay, I had a chance to look at our gris-config, and it's definitely missing the -lTPeakFitting flag. I included that now. I have included it in the grsilibs variable, not the detlibs variable, but as far as I can see there's no difference between those two, you will always get grsilibs followed by detlibs, whether you use --libs, or --all-libs.

I also fixed a mistake where using --libs --all-libs would drop the ```-lX11 -lXpm -lProof -lGuiHtml -lMinuit -lSpectrum -lMathMore`` stuff.

I still don't understand why the order would matter, there must be some kind of bug in the gcc linker.

[cnatzke]

Sounds good. Have you pushed this change to the main branch yet? I'll test it against compiling my code.

[VinzenzBildstein]

Yes, those changes have been pushed (just now).

[cnatzke]

I still needed to switch the order of -lTGRSIFit and -lTGROOT for everything to work.

I changed detlibs to

detlibs="-lTSuppressed -lTBgo -lTPulseAnalyzer -lTGRSIFit -lGROOT -lTNucleus"

and everything compiled correctly.