You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, (e.g. in GRAMRLevel::variableSetUp()), the derived variables are hardcoded to being the constraint ones (i.e. Ham, Mom1, Mom2 and Mom3).
Since we don't want to specialise to GR/CCZ4 examples at the level of GRAMRLevel, we should move this code to the relevant examples and also add an interface so that it is simple for developers of new examples to add their own derived variables.
We should also remove any references to the GRChombo concept of "diagnostic variables" and replace them with derived variables.
Currently, (e.g. in
GRAMRLevel::variableSetUp()
), the derived variables are hardcoded to being the constraint ones (i.e.Ham
,Mom1
,Mom2
andMom3
).Since we don't want to specialise to GR/CCZ4 examples at the level of
GRAMRLevel
, we should move this code to the relevant examples and also add an interface so that it is simple for developers of new examples to add their own derived variables.We should also remove any references to the GRChombo concept of "diagnostic variables" and replace them with derived variables.
Resolving this issue is a dependency of #2.
The text was updated successfully, but these errors were encountered: