Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of derived variables #41

Closed
mirenradia opened this issue Jan 9, 2024 · 1 comment · Fixed by #63
Closed

Refactor handling of derived variables #41

mirenradia opened this issue Jan 9, 2024 · 1 comment · Fixed by #63
Assignees
Labels
enhancement New feature or request

Comments

@mirenradia
Copy link
Member

Currently, (e.g. in GRAMRLevel::variableSetUp()), the derived variables are hardcoded to being the constraint ones (i.e. Ham, Mom1, Mom2 and Mom3).

Since we don't want to specialise to GR/CCZ4 examples at the level of GRAMRLevel, we should move this code to the relevant examples and also add an interface so that it is simple for developers of new examples to add their own derived variables.

We should also remove any references to the GRChombo concept of "diagnostic variables" and replace them with derived variables.

Resolving this issue is a dependency of #2.

@mirenradia mirenradia added the enhancement New feature or request label Jan 9, 2024
@mirenradia mirenradia self-assigned this Jan 9, 2024
@mirenradia
Copy link
Member Author

I've decided to rename UserVariables to StateVariables for consistency with AMReX terminology. I hope that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant