-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge drop
and keepends
kwargs
#2258
Comments
drop
and keepends
kwargs.drop
and keepends
kwargs
I agree it's better to have them consistent. We could just support both |
In my opinion, this one is a bit tricky because changing/removing kwargs ruins backwards compatibility for everyone using the |
I agree, I had the same thoughts. There's no need to remove We could do some poll whether |
|
Note that .readlines might need to be compatible with file-like .readlines. Not sure if it is the case, but see what happened after refactoring term.readline for instance. |
|
recvuntil()
usesdrop
kwarg, whilerecvline()
andrecvlines()
usekeepends
.keepends
is a logical negation ofdrop
, while both serve the same purpose. I find this unnecessarily confusing.I would like to propose using the same kwarg for the purpose of those functions.
It's a matter of discussion whether
drop
orkeepends
or maybe a new different keyword is better.The new keyword can be added while preserving the old behaviour.
The text was updated successfully, but these errors were encountered: