Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cargo test --features=serde" fails on i686 #56

Open
jamessan opened this issue May 5, 2024 · 0 comments · May be fixed by #57
Open

"cargo test --features=serde" fails on i686 #56

jamessan opened this issue May 5, 2024 · 0 comments · May be fixed by #57

Comments

@jamessan
Copy link

jamessan commented May 5, 2024 

failures:
 
 ---- tests::test_data_ptr_alignment stdout ----
 thread 'tests::test_data_ptr_alignment' panicked at 'assertion failed: v.data_raw() as usize % 8 == 0', src/lib.rs:2666:9
jamessan added a commit to jamessan/thin-vec that referenced this issue May 7, 2024
@jamessan
Use core::mem::align_of to determine proper type aligment
1fa28a7 
On i686, the u64 test sometimes fails because the required alignment is
4-bytes, not 8-bytes.

Closes Gankra#56
Co-authored-by: Peter Michael Green <[email protected]>
@jamessan jamessan linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use core::mem::align_of to determine proper type aligment jamessan/thin-vec
1 participant
@jamessan