Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: Misrepresented missing data #233

Open
angiehjort opened this issue May 27, 2021 · 3 comments
Open

BC: Misrepresented missing data #233

angiehjort opened this issue May 27, 2021 · 3 comments

Comments

@angiehjort
Copy link
Member

image

@jheeffer
Copy link
Member

jheeffer commented May 27, 2021

Right, because y is required, y1 isn't, so markers/rows where y1 is null are included in result.

What is expected behavior?

  1. Different bubbles per chart : easiest is before drawing a bubble, check if x/y/size are valid values. Not sure yet how to do this in core: we have one row per marker, we'd have to split up the dataMap or smth. Two markers maybe with only y encoding different.

  2. Bubbles limited to intersection of available bubbles : add y1 to requiredEncodings

@jheeffer
Copy link
Member

jheeffer commented Jun 1, 2021

Btw, core now supports

requiredEncodings: [{ '$or': ['y','y1'] }, 'x', 'size']

So you can include a marker when either y encoding has data.
Doesn't fix this, because the other y -encoding might still be null and end up with the above picture. You'll definitely have to check if x/y/size is null before drawing if you're going for case 1, regardless if you use the $or or not.

@jheeffer
Copy link
Member

jheeffer commented Jun 1, 2021

Right, because y is required, y1 isn't, so markers/rows where y1 is null are included in result.

What is expected behavior?

  1. Different bubbles per chart : easiest is before drawing a bubble, check if x/y/size are valid values. Not sure yet how to do this in core: we have one row per marker, we'd have to split up the dataMap or smth. Two markers maybe with only y encoding different.
  2. Bubbles limited to intersection of available bubbles : add y1 to requiredEncodings

I guess this was not the reason, it was because ammending encoding data fetching had some error which we already fixed.
But what I'm pointing out here probably would still happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants