Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change data source file structure #57

Closed
Itaykal opened this issue Mar 25, 2023 · 2 comments
Closed

Suggestion: Change data source file structure #57

Itaykal opened this issue Mar 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Itaykal
Copy link
Contributor

Itaykal commented Mar 25, 2023

TL;DR - Make each data source a package instead of a module.

Changing data_sources folder to contain foldersinstead of a file for each source.

It will make the code less "monolithic" without creating a meess, you could implement your own clients/wrappers for those clients which will make the code much more easy to maintain. add files for testing, etc etc.

Have a look at CloudQuery's solution. (although it's an extremely different product for a different use case..)
I guess it's better to do that sooner than later ;/

@rishi003
Copy link

I was looking at the data_sources folder too, and I completely agree. A structure would make it more maintainable overall. I would also recommend using a mono repo tooling for the entire project.

@bary12 bary12 added the enhancement New feature or request label Mar 26, 2023
@Roey7
Copy link
Contributor

Roey7 commented Mar 26, 2023

Done in #60

@Roey7 Roey7 closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants