Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing displayName field in Google Drive source indexing #68

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Fix missing displayName field in Google Drive source indexing #68

merged 3 commits into from
Mar 30, 2023

Conversation

teynar
Copy link
Contributor

@teynar teynar commented Mar 27, 2023 •
edited
Loading

fixes #67

@Roey7
Copy link
Contributor

Roey7 commented Mar 27, 2023

Can you check if there is any other author to provide in such scenario?

@teynar
Copy link
Contributor Author

teynar commented Mar 28, 2023

Can you check if there is any other author to provide in such scenario?

One option would be to use one of the owners of the file via owners[].displayName or all or their names separated by commas

@Roey7
Copy link
Contributor

Roey7 commented Mar 28, 2023

@teynar aight owners[0].displayName sounds ok

@Roey7 Roey7 merged commit f7f7c06 into GerevAI:main Mar 30, 2023
@Roey7
Copy link
Contributor

Roey7 commented Mar 30, 2023

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Drive source file processing fails due to missing lastModifyingUser.displayName field
3 participants
@teynar @Roey7 @realech