Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect organisation link on dataset detail pages #73

Open
neuronick opened this issue Mar 24, 2021 · 1 comment
Open

Incorrect organisation link on dataset detail pages #73

neuronick opened this issue Mar 24, 2021 · 1 comment
Labels
bug Something isn't working frontend

Comments

@neuronick
Copy link

When on dataset detail page you click on Organisation icon/logo or Organisation title, the link is incorrect and leads tot 'Page not found'.

Steps to reproduce the behavior:

  1. Go to dataset detail page (e.g.: https://demo.getdkan.org/dataset/1f2042ad-c513-4fcf-a933-cae6c6fd35e6)
  2. Click on the Organisation icon or on the dataset title 'National Health Council' (top left conner)
  3. 404 / Page not found will be shown

Expected behavior
The organisation link generated is:
https://demo.getdkan.org/dataset/1f2042ad-c513-4fcf-a933-cae6c6fd35e6/search?publisher__name=National%20Health%20Council
While it should be:
https://demo.getdkan.org/search?publisher__name=National%20Health%20Council

Screenshots
image

@neuronick neuronick added bug Something isn't working frontend labels Mar 24, 2021
@dgading
Copy link
Member

dgading commented Apr 9, 2021

Thanks for catching this, there was a missing / in the component. This is partially fixed in this commit but there is another link missed.

This should be fixed with GetDKAN/data-catalog-components@90c1afa

https://demo.getdkan.org/dataset/1f2042ad-c513-4fcf-a933-cae6c6fd35e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

2 participants