Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to open links in new tab (seems simple, it probably already exists, but I don't know how to do it) #2468

Open
firmai opened this issue Sep 13, 2024 · 1 comment
Labels

Comments

@firmai
Copy link

firmai commented Sep 13, 2024

Bug description

Recent changes to GitBook have modified link behavior, causing all links to open in the same tab. This creates significant complications when GitBook documents are embedded as iFrames in other websites, as security rules may prevent external links from displaying properly.

This issue affects user experience, workflow, and the functionality of GitBook content when embedded in other platforms. Users are unable to access external links when the content is embedded, disrupting information flow and reducing the utility of GitBook documentation.

How to reproduce

  1. Embed a GitBook document containing external links into another website using an iFrame.
  2. Navigate to the embedded GitBook content on the website.
  3. Attempt to click on an external link within the GitBook content.
  4. Observe that instead of opening in a new tab, the link either fails to load or displays a connection error due to security restrictions.

Additional context

  • This issue particularly impacts organizations and users who frequently embed GitBook content in their own websites or platforms.
  • The previous behavior of opening links in new tabs was more compatible with embedded scenarios and aligned with common web conventions.
  • A configurable option to choose between opening links in the current tab or a new tab would resolve this issue while maintaining flexibility for different use cases.
  • This bug significantly impacts the usability and effectiveness of GitBook as a documentation platform, especially in scenarios where content needs to be integrated with other systems.

Edit: I am using the deployed paid version

@firmai firmai added the bug label Sep 13, 2024
@Frits-Ritense
Copy link

In a previous feature request (#577) we got an explanation from @SamyPesse on why links do not open on a new Tab. This feature request however was regarding embedding Gitbook in an iframe.

Please consider our customers that have reached the documentation site of our product. Each external link in our documentation immediately moves the customer away from the documentation site again. This is not preferred. We place external links to other sites for additional information but we need to keep the customer in our documentation pages.

We are not requesting to change the default option for external links. We just want the possibility to decide for ourselves if a link should open on a new tab. Gitbook is the first product we use that does not allow this at all.

Please reconsider to make a "Open in new tab" option available for external links in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants