Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional output fields to the project data query #7

Merged
merged 6 commits into from
Feb 23, 2025

Conversation

Meriem-BM
Copy link
Member

@Meriem-BM Meriem-BM commented Feb 21, 2025

#1

@Meriem-BM Meriem-BM requested a review from aminlatifi February 22, 2025 09:49
Copy link
Member

@aminlatifi aminlatifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Meriem-BM for great work.
Just donations are missed! I know it's not explicitly mentioned, but we need donation data as well. To support them, I reckon we have no way other than defining donation entity and create one node per donation and connect it to the project with a connection.

What is mentioned:

Project DONATION Link (String) = Link

Comment on lines +144 to +154
polygon_address TEXT,
celo_address TEXT,
base_address TEXT,
solana_address TEXT,
ethereum_address TEXT,
arbitrum_address TEXT,
optimism_address TEXT,
gnosis_address TEXT,
stellar_address TEXT,
zkevm_address TEXT,
ethereum_classic_address TEXT,
Copy link
Member

@aminlatifi aminlatifi Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your way would be more efficient in generating queries with LLM.
My first idea was to define addresses as separate entities/nodes, and then connect them to their corresponding project with a "HAS" relation.
Let's go as you have implemented it, thanks.

@aminlatifi aminlatifi merged commit 522743f into main Feb 23, 2025
@aminlatifi aminlatifi deleted the feat/additonal_output_fields branch February 23, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants