Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects: Multi-Tap support for Presets to update Echo Tempo #74

Open
FrostyCoolSlug opened this issue May 16, 2023 · 1 comment
Open

Comments

@FrostyCoolSlug
Copy link
Member

So according to the manual, and seemingly in the official app, repeatedly tapping on a effect preset button will adjust the echo tempo value.

From some basic testing and investigation, the app seems to create an array of size 4 which is initially filled with the current value. A BPM value is calculated between the last two presses of the button (based on I would assume time) which replaces an entry in the array and a new BPM is calculated as an average.

Find a way to smartly implement this :D

@a2hsh
Copy link

a2hsh commented May 17, 2023

Also, if I may add:

  1. When the tempo calculation process starts, stop announcing the preset name on button press to SRS; as they might confuse users who want to sync the tempo with the music they're hearing.
  2. When the tempo calculation process stops, and after the timer passes the 1 second mark and gets canceled, announce the current tempo to SRS, and go back to the default behavior, which is announcing the preset's name on button click.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants