Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German writing conventions uses a comma (+fix included) #50

Open
NoTaubsi opened this issue Jul 26, 2023 · 1 comment
Open

German writing conventions uses a comma (+fix included) #50

NoTaubsi opened this issue Jul 26, 2023 · 1 comment
Assignees

Comments

@NoTaubsi
Copy link

NoTaubsi commented Jul 26, 2023

Hello,

German writing norms use a comma instead of a dot to separate numbers such as "1.1/1,1". This is a regular issue on german realms, as "1,6k" will register as "6k".

I made a fork and a simple change in the RegEx to GDKPd.lua to fix this, you can find it here: NoTaubsi@fa07696
This keeps the current functionability, but adds the feature of using commas.

I'm new to GitHub, I hope you find this helpful. Your Discord invite link is out of date by the way.

@NoTaubsi NoTaubsi changed the title German writing conventions uses a comma German writing conventions uses a comma (+fix included) Jul 26, 2023
@KaylinFinke KaylinFinke self-assigned this Sep 11, 2023
@KaylinFinke
Copy link
Collaborator

I wasn't able to get this code to work for me locally (enUS locale). I recognize the need for this functionality though and it's even an issue on the US realms. I'll look into it more closely soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants