Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement/Cancelled transactions are not handled in the pending/confirmed cycle #144

Open
2 tasks
L03TJ3 opened this issue Feb 14, 2022 · 1 comment
Open
2 tasks

Replacement/Cancelled transactions are not handled in the pending/confirmed cycle #144

L03TJ3 opened this issue Feb 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 14, 2022 •
edited by sirpy
Loading

Bug Description
as noticed by pat.
image
image

replacement tx make the pending cycle of the initial tx stuck on pending forever

Steps to Reproduce

  1. Make transaction (swap / stake whatever)
  2. Speed up
  3. see error message and stuck pending indicator

Expected Behavior
Error should be catched and TX should be removed from pending queue and the pending toast should disappear

Additional Context
MetaMask/metamask-extension#9174

Definition of Done

  • unmined TX after timeout is not in pending list
  • toast of pending TX is removed after TX timeout
@L03TJ3 L03TJ3 added the bug Something isn't working label Feb 14, 2022
@L03TJ3 L03TJ3 changed the title Replacement transactions are not handled in the pending/confirmed cycle Replacement/Cancelled transactions are not handled in the pending/confirmed cycle Feb 14, 2022
@L03TJ3 L03TJ3 assigned ghost Feb 21, 2022
@sirpy sirpy assigned YpetrovAJ and unassigned ghost Feb 21, 2022
@GoodDollar GoodDollar deleted a comment from L03TJ3 Feb 21, 2022
@sirpy
Copy link
Contributor

sirpy commented Feb 21, 2022

@YpetrovAJ see expected behaviour and DOD in issue description

@1ucius 1ucius assigned 1ucius and unassigned YpetrovAJ Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sirpy @L03TJ3 @1ucius @YpetrovAJ