Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Uniswap widget shows error when high price-impact #576

Open
1 task
L03TJ3 opened this issue Nov 3, 2024 · 1 comment
Open
1 task

Bug: Uniswap widget shows error when high price-impact #576

L03TJ3 opened this issue Nov 3, 2024 · 1 comment
Assignees

Comments

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Nov 3, 2024

Bug Description
When doing a trade which has a 100% price-impact, the uniswap widget breaks with 'something went wrong'

This is a calculation error (Division by zero):
image

Steps to Reproduce

  1. Go to gooddapp.org
  2. go to swap
  3. set pair G$ > cUsd
  4. fill in amount below <30 G$
  5. see result
  6. compare with using app.uniswap, which shows output as 0 for cUsd and a price-impact warning of 100%

...

Expected Behavior
High-price impact of 100% should be shown to user and not show confusing error message.

Proposed solution

  • uniswap/widgets barely gets updated or pull-requests merged. so the solution should likely be handled by a patch
@L03TJ3 L03TJ3 added the bug Something isn't working label Nov 3, 2024
@GoodDollar GoodDollar deleted a comment Nov 4, 2024
@decentralauren
Copy link
Contributor

@L03TJ3 add Uniswap ticket link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants