Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not generating enough context #2

Closed
bokand opened this issue Jun 19, 2020 · 1 comment
Closed

Not generating enough context #2

bokand opened this issue Jun 19, 2020 · 1 comment
Assignees

Comments

@bokand
Copy link
Collaborator

bokand commented Jun 19, 2020

Here's an interesting case:

I was trying to copy a link to this text but the extension gave up due to uniqueness.

Turns out on GitHub it's common to have text quoted which means large sections will be non unique. It's a bit of an edge case for our algorithm.

However, in this case, simply using the last few words of the previous numbered list entry works as disambiguating context. I haven't had a chance to dig into the code yet but it looks like the extension isn't (correctly) crossing the block boundary to find context when the match starts at a block boundary.

@tomayac tomayac self-assigned this Jun 19, 2020
@tomayac
Copy link
Member

tomayac commented Jun 19, 2020

I’ll have a look after the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants