Number of retries in the register_cluster() function should be more than 2

[jacekszlachtass]

The number of retries in the register_cluster() function should be more than 2:

anthos-service-mesh-packages/asmcli/asmcli

Line 3623 in 4753ebb

retry 2 run_command ${CMD}

I got this error twice in a row:

#asmcli: Registering the cluster as fow-sandbox-fow-sandbox-europe-west2...
#asmcli: [WARNING]: Failed, retrying...(1 of 2)
#asmcli: [WARNING]: Failed, retrying...(2 of 2)
#asmcli: [WARNING]: Command 'run_command gcloud container hub memberships register fow-sandbox-fow-sandbox-europe-west2 --project=fow-sandbox --enable-workload-identity --gke-uri=https://container.googleapis.com/v1/projects/fow-sandbox/locations/europe-west2/clusters/fow-sandbox' failed.

The solution was to manually run the command from the error message and re-run the asmcli command again.

[jacekszlachtass]

Looks like the problem is not the number of retries, but the fact that it quickly fails. I tried with a higher number of retries, but without any luck. The only way around it is to manually run the "gcloud" command, which takes a while, and then re-run asmcli.

[jacekszlachtass]

And the latest output:

asmcli: Verifying cluster registration.
asmcli: Registering the cluster as fow-sandbox-5udocewp...
asmcli: [WARNING]: Failed, retrying...(1 of 2)
asmcli: [WARNING]: Failed, retrying...(2 of 2)
asmcli: [WARNING]: Command 'run_command gcloud container hub memberships register fow-sandbox-5udocewp --project=fow-sandbox --enable-workload-identity --gke-uri=https://container.googleapis.com/v1/projects/fow-sandbox/locations/europe-west2/clusters/fow-sandbox' failed.
❯ gcloud container hub memberships register fow-sandbox-5udocewp --project=fow-sandbox --enable-workload-identity --gke-uri=https://container.googleapis.com/v1/projects/fow-sandbox/locations/europe-west2/clusters/fow-sandbox
kubeconfig entry generated for fow-sandbox.
Waiting for membership to be created...done.
Created a new membership [projects/fow-sandbox/locations/global/memberships/fow-sandbox-5udocewp] for the cluster [fow-sandbox-5udocewp]
Generating the Connect Agent manifest...
Deploying the Connect Agent on cluster [fow-sandbox-5udocewp] in namespace [gke-connect]...
Deployed the Connect Agent on cluster [fow-sandbox-5udocewp] in namespace [gke-connect].
Finished registering the cluster [fow-sandbox-5udocewp] with the Fleet.

[zerobfd]

Thanks for the report! Do you remember about how long the command took to run? I can adjust the timeout.

[jacekszlachtass]

Hm, good question, something like 30-40 seconds. It is not quick, a timeout of 1 minute would probably make sense.