Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used #673

Open
caugner opened this issue Feb 3, 2025 · 0 comments · May be fixed by #674
Open

v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used #673

caugner opened this issue Feb 3, 2025 · 0 comments · May be fixed by #674
Assignees
@HKWinterhalter

Comments

@caugner
Copy link

caugner commented Feb 3, 2025

In 16709c6, @matthewrobertson bumped @types/express from 4.17.21 to ^5.0.0, which probably wasn't intended.

This causes issues, because the RouteParameters type in @types/express-serve-static-core, which is used by @types/express, changed slightly between v4 and v5

This caused unexpected issues for us when upgrading dependencies in https://github.com/mdn/yari/blob/main/cloud-function/package.json, as @sentry/google-cloud-serverless 8.54.0 expects express v4 types.
@caugner caugner changed the title v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used Feb 3, 2025
This was referenced Feb 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HKWinterhalter HKWinterhalter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): downgrade @types/express to v4 caugner/functions-framework-nodejs
2 participants
@caugner @HKWinterhalter