Skip to content

Commit

Permalink
fix: Correct syntax errors in PCM processor (#1569)
Browse files Browse the repository at this point in the history
# Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [X] Follow the [`CONTRIBUTING`
Guide](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/CONTRIBUTING.md).
- [ ] You are listed as the author in your notebook or README file.
- [ ] Your account is listed in
[`CODEOWNERS`](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/.github/CODEOWNERS)
for the file(s).
- [X] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- [ ] Ensure the tests and linter pass (Run `nox -s format` from the
repository root to format).
- [ ] Appropriate docs were updated (if necessary)

Fixes #1567
  • Loading branch information
heiko-hotz authored Dec 20, 2024
1 parent 3b51a0f commit 006fd84
Showing 1 changed file with 24 additions and 30 deletions.
Original file line number Diff line number Diff line change
@@ -1,40 +1,34 @@
class PCMProcessor extends AudioWorkletProcessor {
constructor() {
super();
this.buffer = new Float32Array();

/**
* @class PCMProcessor
* @extends AudioWorkletProcessor
* @description Processes PCM audio data.
* @description Processes PCM audio data in a Web Audio API context
*/
this.port.onmessage = (e) => {
const newData = e.data;
const newBuffer = new Float32Array(this.buffer.length + newData.length);
newBuffer.set(this.buffer);
newBuffer.set(newData, this.buffer.length);
this.buffer = newBuffer;
};
const newData = e.data;
const newBuffer = new Float32Array(this.buffer.length + newData.length);
newBuffer.set(this.buffer);
newBuffer.set(newData, this.buffer.length);
this.buffer = newBuffer;
};
}
class PCMProcessor extends AudioWorkletProcessor {
constructor() {
super();
this.buffer = new Float32Array();

process(inputs, outputs, parameters) {
const output = outputs[0];
const channelData = output[0];
this.port.onmessage = (e) => {
const newData = e.data;
const newBuffer = new Float32Array(this.buffer.length + newData.length);
newBuffer.set(this.buffer);
newBuffer.set(newData, this.buffer.length);
this.buffer = newBuffer;
};
}

if (this.buffer.length >= channelData.length) {
channelData.set(this.buffer.slice(0, channelData.length));
this.buffer = this.buffer.slice(channelData.length);
return true;
}
process(inputs, outputs, parameters) {
const output = outputs[0];
const channelData = output[0];

return true;
if (this.buffer.length >= channelData.length) {
channelData.set(this.buffer.slice(0, channelData.length));
this.buffer = this.buffer.slice(channelData.length);
return true;
}

return true;
}
}

registerProcessor('pcm-processor', PCMProcessor);
registerProcessor("pcm-processor", PCMProcessor);

0 comments on commit 006fd84

Please sign in to comment.