Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistent model variable naming in evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb #1691

Closed
1 task done
pmorrisgit opened this issue Feb 4, 2025 · 1 comment · Fixed by #1701
Closed
1 task done
Assignees

Comments

@pmorrisgit
Copy link

File Name

gemini/evaluation/evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb

What happened?

Inconsistent model variable naming in evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb

There is an inconsistency in the model variable naming within the notebook evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb. This may cause confusion for users and potentially lead to errors when running the notebook.

Location of the issue:

File: evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb
Section: 'Prompt engineering'

Details:

In the subsection 'Define a model', the model is defined as:

gemini_model = GenerativeModel(

However, in the subsection 'Run Evaluation' (two sections later), the model is referenced as:

model=model,

Expected behavior:

The model variable should be consistently named throughout the notebook to avoid confusion and potential errors.

Suggested fix:

Update the 'Run Evaluation' section to use the correct variable name:

model=gemini_model,

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@holtskinner
Copy link
Collaborator

@jsondai Can you work on this?

leebaro pushed a commit to leebaro/generative-ai that referenced this issue Feb 7, 2025
)

fix: remove inconsistent model variable naming in
evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb


Fixes GoogleCloudPlatform#1691  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants