Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: DATA_STORE_NAME formatting is ommiting DATA_STORE_REGION #1724

Closed
1 task done
allanton opened this issue Feb 11, 2025 · 0 comments · Fixed by #1728
Closed
1 task done

[Bug]: DATA_STORE_NAME formatting is ommiting DATA_STORE_REGION #1724

allanton opened this issue Feb 11, 2025 · 0 comments · Fixed by #1728

Comments

@allanton
Copy link
Contributor

allanton commented Feb 11, 2025 •
edited by holtskinner
Loading

File Name

gemini/grounding/intro-grounding-gemini.ipynb

What happened?

In the "Creating a data store in Vertex AI Search" section, when we format DATA_STORE_NAME string, DATA_STORE_REGION variable is ommited and location is set to US by default.

DATA_STORE_NAME = f"projects/{PROJECT_ID}/locations/us/collections/default_collection/dataStores/{DATA_STORE_ID}"

==>

DATA_STORE_NAME = f"projects/{PROJECT_ID}/locations/{DATA_STORE_REGION}/collections/default_collection/dataStores/{DATA_STORE_ID}"

Code of Conduct

  • I agree to follow this project's Code of Conduct
This was referenced Feb 11, 2025
Closed
Merged
holtskinner pushed a commit that referenced this issue Feb 11, 2025
@allanton
fix: Update DATA_STORE_NAME formatting (#1728)
b4f67e4 
# Description

Fixes a minor formatting issue in the intro to gemini grounding
notebook.

Fixes #1724 🦕
leebaro pushed a commit to leebaro/generative-ai that referenced this issue Feb 20, 2025
@allanton @leebaro
fix: Update DATA_STORE_NAME formatting (GoogleCloudPlatform#1728)
ef75cd0 
# Description

Fixes a minor formatting issue in the intro to gemini grounding
notebook.

Fixes GoogleCloudPlatform#1724 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@allanton